Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - vector of float & double does not derive Eq #1158

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

billy1624
Copy link
Member

PR Info

Fixes

  • [cli] generate model with Vec<f32> / Vec<f64> should not derive Eq on the model struct

@@ -1182,7 +1213,7 @@ mod tests {
#[test]
fn test_gen_expanded_code_blocks() -> io::Result<()> {
let entities = setup();
const ENTITY_FILES: [&str; 9] = [
Copy link
Member

@tyt2y3 tyt2y3 Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try [_; _]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish that works. Seems it's coming but not on stable Rust just yet

@tyt2y3 tyt2y3 merged commit 5e0c625 into master Oct 26, 2022
@tyt2y3 tyt2y3 deleted the fix-vec-floats-not-derive-eq branch October 26, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Eq is not implemented for Vec<f64> error when using "postgress-array" feature
2 participants