Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrast issue on brand color #518

Open
raynecloudy opened this issue Jan 20, 2025 · 6 comments
Open

Contrast issue on brand color #518

raynecloudy opened this issue Jan 20, 2025 · 6 comments

Comments

@raynecloudy
Copy link
Contributor

i'm surprised nobody else has brought this up yet

white-on-orange

black-on-orange

@Secret-chest
Copy link
Contributor

@Samq64
Copy link
Member

Samq64 commented Jan 20, 2025

There is also an issue about this on the main repository. ScratchAddons/ScratchAddons#7357

@Hans5958
Copy link
Member

Yep. This is a problem that I'm aware, but unsure of what to do. I'm trying to create a higher constrast by darkening the orange to get it to at least AA, but it's kind of ugly. At least the dark mode is quite contrast.

Anyways, this should be handled on the extension side, as it follows the design of the extension. I will still open the issue just so we remember to update it.

@Hans5958 Hans5958 changed the title white-on-orange colour contrast issues Contrast issue on brand color Jan 21, 2025
Hans5958 added a commit that referenced this issue Jan 21, 2025
@Hans5958
Copy link
Member

I just remembered this: I actually have adjusted the colors when prefers-contrast: more. I adjusted more of the colors (not just the brand orange), and now it should be like this.

Image

@raynecloudy
Copy link
Contributor Author

I just remembered this: I actually have adjusted the colors when prefers-contrast: more. I adjusted more of the colors (not just the brand orange), and now it should be like this.

oh, that's awesome. i didn't even know that media query existed until right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants