-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto filter code based on flags #46 #47
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 84.35% 85.63% +1.27%
==========================================
Files 5 5
Lines 326 355 +29
==========================================
+ Hits 275 304 +29
Misses 51 51 ☔ View full report in Codecov by Sentry. |
The main code looks good to me. |
@DLumi given a game as overwatch that's like
And has
Would you put to None all comp_main, comp_plus, comp_100, comp_all? |
Yep, I think this is how they treat it on the site. And it makes sense to me |
@DLumi updated, tell me if you like it this way |
Yeah, I think this works, thank you! |
See discussion #46