Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto filter code based on flags #46 #47

Merged
merged 6 commits into from
Feb 18, 2025
Merged

Conversation

ScrappyCocco
Copy link
Owner

@ScrappyCocco ScrappyCocco commented Feb 18, 2025

See discussion #46

@ScrappyCocco ScrappyCocco self-assigned this Feb 18, 2025
@ScrappyCocco ScrappyCocco added the enhancement New feature or request label Feb 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.63%. Comparing base (1279872) to head (9050bdb).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   84.35%   85.63%   +1.27%     
==========================================
  Files           5        5              
  Lines         326      355      +29     
==========================================
+ Hits          275      304      +29     
  Misses         51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DLumi
Copy link

DLumi commented Feb 18, 2025

The main code looks good to me.
But I think I'd also filter single player values, too. Think of the multiplayer-exclusive games like Overwatch 2, TF2 or Dota 2, that do not have a single player campaign in the traditional sense

@ScrappyCocco
Copy link
Owner Author

@DLumi given a game as overwatch that's like

"comp_lvl_combine": 0,
"comp_lvl_sp": 0,
"comp_lvl_co": 0,
"comp_lvl_mp": 1,

And has

"comp_main": 346671,
"comp_plus": 713078,
"comp_100": 2132164,
"comp_all": 754821,
"invested_co": 1067284,
"invested_mp": 1150129,

Would you put to None all comp_main, comp_plus, comp_100, comp_all?

@DLumi
Copy link

DLumi commented Feb 18, 2025

Yep, I think this is how they treat it on the site. And it makes sense to me

@ScrappyCocco
Copy link
Owner Author

@DLumi updated, tell me if you like it this way

@DLumi
Copy link

DLumi commented Feb 18, 2025

Yeah, I think this works, thank you!

@ScrappyCocco ScrappyCocco merged commit bbc840d into master Feb 18, 2025
4 checks passed
@ScrappyCocco ScrappyCocco deleted the auto_filtering branch February 18, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants