Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDE-160 - limit the number of posts per email for daily digests #72

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

rohar
Copy link
Contributor

@rohar rohar commented Aug 21, 2019

Ensures each section gets at least 1 post and any "spare" posts are greedily consumed on a first come, first served basis.

Copy link
Contributor

@antreaspas antreaspas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change to be made, and happy with the greedy approach. I think it's worth creating a new story to investigate and implement the "evenly trimmed posts" algorithm

functions/calculateUserDailyDigest.js Show resolved Hide resolved
@antreaspas antreaspas merged commit ae796ad into master Aug 22, 2019
@antreaspas antreaspas deleted the SDE-160-daily-digest-post-limit branch August 22, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants