Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat dropdown menu doesnt work with Stubby #3

Closed
Daimie opened this issue Mar 12, 2017 · 2 comments
Closed

Chat dropdown menu doesnt work with Stubby #3

Daimie opened this issue Mar 12, 2017 · 2 comments

Comments

@Daimie
Copy link

Daimie commented Mar 12, 2017

The following error shows when trying to right-click a chat menu while Stubby addon (which is required for several important addons such as Auctioneer, Informant, Enchantrix) is enabled:

Error: Interface\FrameXML\UIDropDownMenu.lua:182: attempt to index local `info' (a nil value)

@ScottHamper
Copy link
Owner

Steps to reproduce:

  1. Install Auctioneer and its dependencies (EnhTooltip, Stubby) from this repo.
  2. Enable ChatSuey and ChatSuey-FontSettings.
  3. Right-click a chat frame tab.

Error does not occur with Informant/Enchantrix installed, only Auctioneer.

@ScottHamper
Copy link
Owner

It looks like ChatSuey's hook for UIDropDownMenu_AddButton is being wiped out somewhere. Once Auctioneer has finished loading, ChatSuey's hook method never gets called again. Annoyingly, it is not obvious where Auctioneer is overwriting the method (though realistically, it probably doesn't matter - it's not like vanilla Auctioneer is going to get patched).

One simple solution is to add Auctioneer as an optional dependency for ChatSuey in order to force ChatSuey to load after Auctioneer. This allows ChatSuey to hook the UIDropDownMenu_AddButton method only after whatever code in Auctioneer would otherwise wipe the hook out. I'm really not a fan of this solution, as it's ultimately working around a bug/poor coding in Auctioneer - Auctioneer is being a "bad tenant" and should ideally be patched to play nice with other addons. However, it seems apparent that this will never happen.

ScottHamper added a commit that referenced this issue Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants