Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Goerli #541

Merged
merged 6 commits into from
Jun 27, 2023
Merged

Remove Goerli #541

merged 6 commits into from
Jun 27, 2023

Conversation

garyghayrat
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Jun 16, 2023

Deploy Preview for jolly-shaw-20fe62 ready!

Name Link
🔨 Latest commit fced06b
🔍 Latest deploy log https://app.netlify.com/sites/jolly-shaw-20fe62/deploys/649ae954ec970c00083b7428
😎 Deploy Preview https://deploy-preview-541--jolly-shaw-20fe62.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@garyghayrat garyghayrat linked an issue Jun 21, 2023 that may be closed by this pull request
@garyghayrat garyghayrat requested review from alexkeating and mds1 June 23, 2023 18:13
Copy link
Collaborator

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there may be one more reference to remove

frontend/src/pages/FAQ.vue Show resolved Hide resolved
Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @garyghayrat, thanks for taking care of this!

@github-actions
Copy link

Coverage after merging remove-goerli into master will be

85.56%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts-periphery/src
   UmbraBatchSend.sol93.55%100%75%94.74%96
   UniswapWithdrawHook.sol77.78%100%50%80%44
umbra-js/src
   ethers.ts88.24%100%78.57%100%
   types.ts50%100%0%100%
umbra-js/src/classes
   KeyPair.ts98.65%96.49%100%100%31–32
   RandomNumber.ts100%100%100%100%
   StealthKeyRegistry.ts100%100%100%100%
   TxHistoryProvider.ts77.55%76.47%66.67%79.31%11, 11, 19–20, 31, 38, 44, 53, 57, 8
   Umbra.ts76.51%64.24%83.33%83.74%122, 125–126, 147, 221–223, 307–310, 372, 380, 380–382, 384, 386, 406, 406, 406–407, 411, 414, 435, 452–453, 535, 552, 565–566, 576–577, 590, 593–594, 624–625, 701, 705, 705, 705–708, 708, 708, 708, 708, 708, 708–709, 709, 709, 709, 709, 709, 709, 709, 709, 709, 709, 711, 711, 711–712, 715, 715, 715, 715, 715–716, 719, 726, 726, 735, 739, 739, 739–740, 753, 757, 760–761, 767–769, 776, 776, 776–779, 810, 815–816, 816–817, 96
umbra-js/src/utils
   cns.ts50%33.33%50%55%33–36, 40, 40, 40, 40, 40–41, 44–46
   constants.ts100%100%100%100%
   ens.ts36.11%25%33.33%40%25–27, 35, 56–57, 57, 57–58, 63–64, 66, 70, 70, 70, 70, 70–71, 75–77
   utils.ts80.65%71.67%86.67%86.29%107–109, 111–113, 119, 137–138, 167, 185, 238, 264, 266–267, 276, 276, 276–277, 279, 282, 291–292, 336, 336, 336, 356, 385, 387, 392, 404, 404–405, 410, 412–413, 424–428, 434, 436, 478–479, 479, 479–481, 481, 481, 57–58, 581, 586, 83, 91, 91
umbra-js/test
   testPrivateKeys.ts100%100%100%100%
   utils.ts100%100%100%100%

@mds1 mds1 merged commit 02080e2 into master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: remove goerli, replace with sepolia
4 participants