Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added the ability to specify @ version when installing from url #5984

Closed
wants to merge 1 commit into from
Closed

added the ability to specify @ version when installing from url #5984

wants to merge 1 commit into from

Conversation

insertokname
Copy link
Contributor

@insertokname insertokname commented May 22, 2024 •
edited
Loading

added the ability to use the @ symbol when using scoop install with a url

Description

Simple change to the regex that matches the name of the app to not require the whole string to be ending with .json

fixes #5977

This has been tested with all installation methods that have been mentioned in the scoop install --help

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@insertokname
Copy link
Contributor Author

Closed so i can make a new pull request that has the signed commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@insertokname