podman: Add data/config/connections persist #6438
Conversation
|
All changes look good. Wait for review from human collaborators. podman
|
bucket/podman.json
Outdated
| "uninstaller": { | ||
| "script": "Remove-Path -Path $dir -TargetEnvVar $scoopPathEnvVar -Global:$global -Force" | ||
| }, | ||
| "env_set": { | ||
| "XDG_DATA_HOME": "$dir\\data", |
There was a problem hiding this comment.
This environment variable will impact numerous other applications. Is there an alternative method?
There was a problem hiding this comment.
According to the doc, it is the most elegant way to config.
Or, I can use the method for config persist directory, like L13 and L43-L46, which avoid the use of environment variable XDG_CONFIG_HOME.
I implemented different methods because I'm not sure which is the preferred way.
There was a problem hiding this comment.
It is advisable to avoid using XDG_CONFIG_HOME imo.
There was a problem hiding this comment.
Updated, now all environment variables start with XDG_ are removed from this PR.
silver886
changed the title
|
@niheaven Is there anything I can do to move this forward? Also, can you look at the other similar PR at ScoopInstaller/Extras#14697? |
|
@niheaven Is there anything I can do to move this forward? :) |
2 similar comments
|
@niheaven Is there anything I can do to move this forward? :) |
|
@niheaven Is there anything I can do to move this forward? :) |
|
I'll test it today |
|
So there's no method to specify podman's data dir except for |
|
And, is there some method (junction or symbolic link) to link scoop's persist dir to |
podman puts their storage/config related code in separate repositories. Ref. https://github.com/containers/storage/blob/main/pkg/homedir/homedir.go#L14 However, these are not applied for all data/config.
No, this PR doesn't create junction, symbolic link, or any linkage. There are three persist directories:
|
|
I found there's a way to improve install and uninstall stability and I pushed a new commit. |
Add the ability to preserve and purge data/config/connections for Podman.
This PR also covered the migration process.
<manifest-name[@version]|chore>: <general summary of the pull request>