Skip to content

Conversation

Scarange
Copy link

@Scarange Scarange commented Sep 27, 2025

close #568

This PR adds support for installing and updating Amazon Corretto 25.

The install and update script is based on the Corretto 23 script.

Summary by CodeRabbit

  • New Features
    • Added Amazon Corretto 25 JDK (Windows x64) package to the catalog.
    • Installs the JDK, adds its bin directory to PATH, and sets JAVA_HOME automatically.
    • Built-in integrity verification using SHA-256 checksums for downloads.
    • Automatic version detection and templated update support to keep installations current.

Copy link

coderabbitai bot commented Sep 27, 2025

Walkthrough

Adds a new Scoop manifest for Amazon Corretto 25 JDK (Windows x64) that defines metadata, 64-bit download URL and SHA‑256, extract directory, PATH and JAVA_HOME env vars, a remote JSON checkver, and autoupdate rules that template the URL and retrieve checksums.

Changes

Cohort / File(s) Summary of Changes
New Scoop manifest: Corretto 25 JDK
bucket/corretto25-jdk.json
Added manifest with metadata (description, homepage, license, version), architecture.64bit download URL and SHA‑256, extract_dir, env updates (PATH, JAVA_HOME), checkver using a remote index JSON with JSONPath+regex, and autoupdate rules templating the download URL and fetching checksum via JSONPath.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant User
  participant Scoop
  participant Manifest as Corretto25 Manifest
  participant CDN as Corretto CDN
  participant Checksums as Checksums JSON

  rect rgb(240,245,255)
    note over User,Scoop: Install flow
    User->>Scoop: scoop install corretto25-jdk
    Scoop->>Manifest: read download URL, extract_dir, env
    Scoop->>CDN: download archive (versioned URL)
    Scoop->>Checksums: fetch/verify SHA‑256
    Scoop->>Scoop: extract to extract_dir
    Scoop->>User: set PATH and JAVA_HOME
  end

  rect rgb(245,255,245)
    note over Scoop,Manifest: Update check
    Scoop->>Manifest: run checkver (index JSON + JSONPath/regex)
    Manifest-->>Scoop: latest version
    alt new version available
      Scoop->>Manifest: apply autoupdate templates (URL, extract_dir)
      Scoop->>Checksums: fetch checksum via JSONPath
      Scoop-->>User: update ready
    else up-to-date
      Scoop-->>User: no update
    end
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Add openjdk25 #554 — Adds JDK 25 manifests and similar manifest-level changes (version, download URL, checkver/autoupdate) for a different JDK distribution.

Suggested reviewers

  • se35710

Poem

Hop, hop — a manifest in springtime sun,
Corretto twenty-five, the downloads run.
Hashes checked, paths set tidy and warm,
JAVA_HOME settles, ready for the storm.
(\_/) ☕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description omits required template sections and checkboxes, uses incorrect “close” syntax instead of the mandated “Closes #568” format, and lacks the checklist confirming review of the contributing guide. Please update the description to follow the repository template by including the commented instructions, using “Closes #568” at the top, and adding the checklist item confirming you have read the Contributing Guide.
✅ Passed checks (4 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title clearly and concisely states the main change by indicating support for Corretto 25 and aligns directly with the addition of the new Corretto 25 manifest without extra noise or ambiguity.
Linked Issues Check ✅ Passed The changes introduce the Corretto 25 manifest with installation, verification, and auto-update rules that satisfy the request in issue #568 to add support for Amazon Corretto 25.
Out of Scope Changes Check ✅ Passed All changes are confined to adding the Corretto 25 manifest file, and there are no modifications to unrelated files or features outside the scope of supporting Corretto 25.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 829125d and 59a8d07.

📒 Files selected for processing (1)
  • bucket/corretto25-jdk.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

corretto25-jdk

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9301e8 and 3bd45fd.

📒 Files selected for processing (1)
  • bucket/corretto25-jdk.json (1 hunks)

@Scarange Scarange force-pushed the corretto-25 branch 2 times, most recently from 829125d to 03e1605 Compare October 8, 2025 01:38
@Scarange
Copy link
Author

Scarange commented Oct 8, 2025

Hi @se35710 would you kindly take a look at this?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Adding Corretto 25
1 participant