-
Notifications
You must be signed in to change notification settings - Fork 104
Added support for Corretto 25 #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughAdds a new Scoop manifest for Amazon Corretto 25 JDK (Windows x64) that defines metadata, 64-bit download URL and SHA‑256, extract directory, PATH and JAVA_HOME env vars, a remote JSON Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant Scoop
participant Manifest as Corretto25 Manifest
participant CDN as Corretto CDN
participant Checksums as Checksums JSON
rect rgb(240,245,255)
note over User,Scoop: Install flow
User->>Scoop: scoop install corretto25-jdk
Scoop->>Manifest: read download URL, extract_dir, env
Scoop->>CDN: download archive (versioned URL)
Scoop->>Checksums: fetch/verify SHA‑256
Scoop->>Scoop: extract to extract_dir
Scoop->>User: set PATH and JAVA_HOME
end
rect rgb(245,255,245)
note over Scoop,Manifest: Update check
Scoop->>Manifest: run checkver (index JSON + JSONPath/regex)
Manifest-->>Scoop: latest version
alt new version available
Scoop->>Manifest: apply autoupdate templates (URL, extract_dir)
Scoop->>Checksums: fetch checksum via JSONPath
Scoop-->>User: update ready
else up-to-date
Scoop-->>User: no update
end
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
All changes look good. Wait for review from human collaborators. corretto25-jdk
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3bd45fd
to
03e1605
Compare
829125d
to
03e1605
Compare
Hi @se35710 would you kindly take a look at this? |
close #568
This PR adds support for installing and updating Amazon Corretto 25.
The install and update script is based on the Corretto 23 script.
Summary by CodeRabbit