Add Temurin JDK25 and JRE25 version 25.0.0-36 to scoop #560
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
WalkthroughAdds two new Scoop manifests for Temurin 25: JDK and JRE (Windows x64). Each includes metadata, architecture-specific URLs and hashes, extract directory, PATH/JAVA_HOME setup, and checkver/autoupdate logic using GitHub API responses and regex parsing. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as User
participant S as Scoop
participant API as GitHub API (Temurin)
participant R as Release Assets
participant H as .sha256.txt
rect rgb(235, 245, 255)
note over U,S: Installation / Update Check
U->>S: scoop install/update temurin25-(jdk|jre)
S->>API: GET /.../releases/25/ga (Windows x64)
API-->>S: JSON of assets (tags, names, links)
S->>S: PowerShell script + regex extract ver/link/name
S-->>U: Version resolved
end
rect rgb(240, 255, 240)
note over S,R: Download and Verify
S->>R: Download ZIP via templated URL
S->>H: Fetch corresponding .sha256.txt
H-->>S: SHA256
S->>S: Verify hash, extract to extract_dir
S->>S: Set PATH (bin) and JAVA_HOME
S-->>U: Installed
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. temurin25-jdk
temurin25-jre
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
bucket/temurin25-jdk.json (1)
17-27: Tighten regex to reduce overmatching and lock to JDK assetsCurrent character class [dejkr]{3} can match unintended triplets. Constrain to jdk explicitly and avoid greedy whitespace matches.
Apply:
- "regex": "(?<ver>.*?) https://github.com/(?<link>.*?)/tag/(?<tag>.*?) (?<name>(?<prefix>OpenJDK[\\dU]*-[dejkr]{3})_x64_(?<suffix>.*))", + "regex": "(?<ver>.*?) https://github.com/(?<link>[^\\s]+)/tag/(?<tag>[^\\s]+) (?<name>(?<prefix>OpenJDK\\d+U-jdk)_x64_(?<suffix>.*))",bucket/temurin25-jre.json (1)
17-27: Tighten regex to reduce overmatching and lock to JRE assetsConstrain to jre explicitly; avoid permissive character class and greedy whitespace.
Apply:
- "regex": "(?<ver>.*?) https://github.com/(?<link>.*?)/tag/(?<tag>.*?) (?<name>(?<prefix>OpenJDK[\\dU]*-[dejkr]{3})_x64_(?<suffix>.*))", + "regex": "(?<ver>.*?) https://github.com/(?<link>[^\\s]+)/tag/(?<tag>[^\\s]+) (?<name>(?<prefix>OpenJDK\\d+U-jre)_x64_(?<suffix>.*))",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
bucket/temurin25-jdk.json(1 hunks)bucket/temurin25-jre.json(1 hunks)
🔇 Additional comments (6)
bucket/temurin25-jdk.json (3)
1-16: Manifest structure and metadata look solidDescription/homepage/version/license, PATH/JAVA_HOME, and extract_dir are consistent with Temurin packaging. Initial URL points to the correct GitHub release artifact name for JDK x64.
28-39: Autoupdate block is correct and consistent with Adoptium layoutURL templating, hash retrieval via .sha256.txt, and extract_dir from tag look good.
8-12: Verify SHA256 and extract_dirAutomation failed (script produced a shell error) — confirm .architecture["64bit"].hash in bucket/temurin25-jdk.json equals the first token from the upstream .sha256.txt (URL at .architecture["64bit"].url) and that extract_dir equals the release tag (decode %2B → +).
bucket/temurin25-jre.json (3)
1-16: Manifest structure and metadata look solidFields align with Temurin JRE packaging. extract_dir jdk-25+36-jre matches expected folder layout.
28-39: Autoupdate block looks correctURL, hash regex, and extract_dir templating with -jre suffix are consistent.
8-12: Verify upstream SHA256 and extract_dir alignment (-jre suffix)Runner couldn't fetch the upstream .sha256.txt so the hash couldn't be validated; extract_dir is "jdk-25+36-jre" which matches tag "jdk-25+36" — confirm the SHA256 in bucket/temurin25-jre.json (66abb3213ce984ecb7b3ae7edfeac2d58622297f8c114eb467518dd63e42aa3f) matches the upstream checksum.
|
Hi @se35710 would you kindly take a look at this? Thanks! |
Add Temurin JDK25 and JRE25 version 25.0.0-36 to scoop
Closes #561