feat: support for no sentinel setup #1987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jokruger the tests are passing, so we can merge but we would need an extra step to merge this new feature into PYBOSSA:
If you need help, let me know it. |
teleyinex
changed the title
|
Please, reopen it when you have the docs part. |
|
🔔 @teleyinex, I'm also interested in this feature and documented it through Scifabric/docs.pybossa.com#57. It would be really nice to have this merged if you deem it opprtune. |
imonthercks
added a commit
to helpfulengineering/project-mechanical-volunteer
that referenced
this pull request
Feb 1, 2021
Based on PR Scifabric/pybossa#1987 that is yet to be merged.
|
Merged with #2007 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of GCP or AWS managed redis services there will be no sentinel (HA is handled by GCP/AWS). So, need a way to setup pybossa to use redis without sentinel.
With this fix you can set REDIS_SENTINEL setting from settings_local.py to None and set REDIS_HOST and REDIS_PORT instead. In this case pybossa will use redis directly.
In case of REDIS_SENTINEL provided, sentinel will be used.