Make Iris backwards compatible with Cartopy #6172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
commented
Oct 11, 2024
Comment on lines
+48
to
+60
| class _GeoAxesPatched(cartopy.mpl.geoaxes.GeoAxes): | ||
| # Workaround for a bug where titles collide with axis labels (cartopy#2390) | ||
| # Bug is only present in Cartopy v0.23, so this will only be invoked for | ||
| # that version. | ||
| def _draw_preprocess(self, renderer): | ||
| super()._draw_preprocess(renderer) | ||
|
|
||
| for artist in self.artists: | ||
| if hasattr(artist, "_draw_gridliner"): | ||
| # Note this is only necessary since Cartopy v0.23, but is not | ||
| # wasteful for earlier versions as _draw_gridliner() includes | ||
| # a check for whether a draw is necessary. | ||
| artist._draw_gridliner(renderer=renderer) |
There was a problem hiding this comment.
Restored from #6171
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6172 +/- ##
==========================================
- Coverage 89.83% 89.81% -0.03%
==========================================
Files 88 88
Lines 23167 23178 +11
Branches 4310 4313 +3
==========================================
+ Hits 20813 20818 +5
- Misses 1623 1628 +5
- Partials 731 732 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: