-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeating Tracemalloc Benchmark for accuracy #5981
Conversation
for more information, see https://pre-commit.ci
I will have this reviewable by Thursday |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5981 +/- ##
=======================================
Coverage 89.78% 89.78%
=======================================
Files 88 88
Lines 23056 23056
Branches 5027 5027
=======================================
Hits 20700 20700
Misses 1624 1624
Partials 732 732 ☔ View full report in Codecov by Sentry. |
⏱️ Performance Benchmark Report: 6e499f4Performance shifts
Full benchmark results
Generated by GHA run |
⏱️ Performance Benchmark Report: 027501fPerformance shifts
Full benchmark results
Generated by GHA run |
This reverts commit 9dffa1b.
We're up to 7 issues that this will close 📈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trexfeathers hopefully this removes some of the noise from memory benchmarks going forward!
Thanks @HGWright! |
A demonstration of how we can use ASV's built-in repetition logic to improve the accuracy oftracemalloc
benchmarking.I welcome anyone who wants to finish this off - I have some other things I need to focus on at the moment.Edit
2024-07-05
Recovering from a disastrous afternoon yesterday, I believe I now have this ready to go. I have tested it and it definitely does benefit from the repeat behaviour by detecting when accuracy prevents certainty about a regression. The in-built reporting for byte measurements is also quite nice, including automatic choice between
KB
/MB
/ etcetera.