Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Add ruff section to the dev guide docs #5701

Merged
merged 13 commits into from
Jan 24, 2024

Conversation

tkknight
Copy link
Contributor

@tkknight tkknight commented Jan 16, 2024

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (adca725) 89.71% compared to head (de85b47) 89.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5701   +/-   ##
=======================================
  Coverage   89.71%   89.71%           
=======================================
  Files          90       90           
  Lines       22816    22816           
  Branches     5438     5438           
=======================================
  Hits        20469    20469           
  Misses       1617     1617           
  Partials      730      730           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkknight tkknight marked this pull request as ready for review January 16, 2024 16:23
@bjlittle bjlittle self-assigned this Jan 18, 2024
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkknight Nice one 👍

Just a couple of minor suggestions to consider.

Thanks for taking the time to draft this up for the dev docs 🍻

docs/src/developers_guide/contributing_ci_tests.rst Outdated Show resolved Hide resolved
docs/src/developers_guide/contributing_ci_tests.rst Outdated Show resolved Hide resolved
docs/src/developers_guide/contributing_ci_tests.rst Outdated Show resolved Hide resolved
docs/src/developers_guide/contributing_ci_tests.rst Outdated Show resolved Hide resolved
@bjlittle bjlittle merged commit b828ffd into SciTools:main Jan 24, 2024
17 checks passed
@tkknight tkknight deleted the ruff_documentation branch January 24, 2024 16:00
acchamber added a commit to acchamber/iris that referenced this pull request Feb 6, 2024
…into shapefile_masking

* 'shapefile_masking' of https://github.com/acchamber/iris: (102 commits)
  [pre-commit.ci] auto fixes from pre-commit.com hooks
  Update lib/iris/_shapefiles.py
  [pre-commit.ci] auto fixes from pre-commit.com hooks
  Numpydocs misc (SciTools#5728)
  Updated environment lockfiles (SciTools#5731)
  Bump codecov/codecov-action from 3 to 4 (SciTools#5727)
  DOCS: API docs ToC more levels (SciTools#5714)
  Bump scitools/workflows from 2024.01.0 to 2024.02.0 (SciTools#5726)
  DOCS: numpydocs 8 (SciTools#5722)
  DOCS: numpydocs 7 (SciTools#5720)
  DOCS: numpydocs 6 (SciTools#5718)
  fix docstring types and remove duplicate line. (SciTools#5719)
  Updated environment lockfiles (SciTools#5717)
  numpydocs (SciTools#5715)
  DOCS: numpydocs 4 (SciTools#5711)
  DOCS: Add ruff section to the dev guide docs (SciTools#5701)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5709)
  Bump scitools/workflows from 2023.12.1 to 2024.01.0 (SciTools#5710)
  Faster trivial equality checks for coordinates and arrays (SciTools#5691)
  Make the Coord.cell method lazy (SciTools#5693)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOCS: Add info about how ruff is used.
2 participants