Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitattrs ncsave redo commonmeta #5538

Merged
merged 11 commits into from
Nov 15, 2023
Merged

Splitattrs ncsave redo commonmeta #5538

merged 11 commits into from
Nov 15, 2023

Commits on Oct 10, 2023

  1. Define common-metadata operartions on split attribute dictionaries.

    @pp-mo
    pp-mo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    d168a89 View commit details
    Browse the repository at this point in the history

  2. Tests for split-attributes handling in CubeMetadata operations.

    @pp-mo
    pp-mo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    c6c3d71 View commit details
    Browse the repository at this point in the history

  3. Small tidy and clarify.

    @pp-mo
    pp-mo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    0d9a4e4 View commit details
    Browse the repository at this point in the history

  4. Common metadata ops support mixed split/unsplit attribute dicts.

    @pp-mo
    pp-mo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    9d17da4 View commit details
    Browse the repository at this point in the history

  5. Clarify with better naming, comments, docstrings.

    @pp-mo
    pp-mo committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    28ebcbb View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Remove split-attrs handling to own sourcefile, and implement as a dec… 

    …orator.
    @pp-mo
    pp-mo committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    8d61d9b View commit details
    Browse the repository at this point in the history

  2. Remove redundant tests duplicated by matrix testcases.

    @pp-mo
    pp-mo committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    fb52624 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Newstyle split-attrs matrix testing, with fewer testcases.

    @pp-mo
    pp-mo committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    2cd51cd View commit details
    Browse the repository at this point in the history

  2. Small improvements to comments + docstrings.

    @pp-mo
    pp-mo committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    07ed579 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Fix logic for equals expectation; expand primary/secondary independen… 

    …ce test.
    @pp-mo
    pp-mo committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    dca5dce View commit details
    Browse the repository at this point in the history

  2. Clarify result testing in metadata operations decorator.

    @pp-mo
    pp-mo committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    b00b37f View commit details
    Browse the repository at this point in the history