Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed units for time coords due to not matching autoticks #5484

Closed
wants to merge 3 commits into from

Conversation

acchamber
Copy link
Contributor

🚀 Pull Request

Description

Draft pull request fixing #5426
Implemented Ruth's suggestion and removed automatic units in axis titles for Time reference units entirely - can't ensure they line up with the autoticks.

Draft because waiting on #5482 to change the image tests to match before pushing and asking for review


Consult Iris pull request check list

@rcomer
Copy link
Member

rcomer commented Sep 7, 2023

Does this make the change from #616 redundant? If so it could be reverted.

@acchamber
Copy link
Contributor Author

I think it does - tests should still pass. Once #5482 fixes the idiff tests I'll check if it can be removed safely.

@trexfeathers
Copy link
Contributor

@acchamber now you have less time for SciTools things, what do you think about the status of this PR?

@acchamber
Copy link
Contributor Author

Trying to rebuild my environment has resulted in environment issues when trying to run idiff.py to update the test results - it can't find iris on import, and I'm not sure why. The code should be fine, but until the test results can be updated it's not ready.

@acchamber
Copy link
Contributor Author

I keep playing with this and I have no clue why it's not working and not the time or patience to keep trying, so I will not be doing any further work on this PR

@rcomer
Copy link
Member

rcomer commented Nov 1, 2023

I will not be doing any further work on this PR

I have pulled this change into #5561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants