Skip to content

Commit

Permalink
Replaced NotImplementedError with NotImplemented (#5544)
Browse files Browse the repository at this point in the history
* Replaced `NotImplementedError` with `NotImplemented`

* Added contribution to `latest.rst`

* Added github handle in the link section
  • Loading branch information
fazledyn-or authored Oct 17, 2023
1 parent 0b569cd commit 447a892
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions docs/src/whatsnew/latest.rst
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,17 @@ This document explains the changes made to Iris for this release
#. `@trexfeathers`_ adapted benchmarking to work with ASV ``>=v0.6`` by no
longer using the ``--strict`` argument. (:pull:`5496`)

#. `@fazledyn-or`_ replaced ``NotImplementedError`` with ``NotImplemented`` as
a proper method call. (:pull:`5544`)


.. comment
Whatsnew author names (@github name) in alphabetical order. Note that,
core dev names are automatically included by the common_links.inc:
.. _@scottrobinson02: https://github.com/scottrobinson02
.. _@acchamber: https://github.com/acchamber
.. _@fazledyn-or: https://github.com/fazledyn-or


.. comment
Expand Down
2 changes: 1 addition & 1 deletion lib/iris/coords.py
Original file line number Diff line number Diff line change
Expand Up @@ -3119,7 +3119,7 @@ def __str__(self):

def __add__(self, other):
# Disable the default tuple behaviour of tuple concatenation
raise NotImplementedError()
return NotImplemented

def xml_element(self, doc):
"""
Expand Down

0 comments on commit 447a892

Please sign in to comment.