Add a simple local file cache for img_tiles. #795
Conversation
| Cache implementation using shelve. | ||
|
|
||
| If appdirs is available, the proper user_cache_dir for the system will | ||
| be used, otherwise the current working directory will be used. |
There was a problem hiding this comment.
I'm not sure that's the best place; there's a config setting that might be a better default.
aeroevan
force-pushed
the
feature/img_tiles_cache
branch
2 times, most recently
from
101f9fa to
6c1833a
Compare
aeroevan
force-pushed
the
feature/img_tiles_cache
branch
from
6c1833a to
0a62adb
Compare
|
what is the status of this PR? Looks like it would be an excellent use case for me. I use jupyter notebooks to tweak plots and I sometimes run the same bounding box with the same tiles dozens of times while I test the different aestethics of the visualization. Caching would be ideal in this case |
pelson
added
Type: Enhancement
SemVer: minor
Blocked: CLA needed
| pass | ||
|
|
||
|
|
||
| class ShelveTileCache(TileCache): |
There was a problem hiding this comment.
Given how easy duck typing is in Python, I would eliminate the TileCache base class
I would also say we should just implement __getitem__ and __setitem__ to make the interface more Pythonic. Or at least that's my inclination.
|
This was superseded by #1533, closing for now, but feel free to reopen if you think there is something else to be done here still. |
This should close #732. This is probably a common enough use case to be included as an option.
Geotiler also includes a redis cache which could easily be added here.