Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shading=None in pcolor(mesh) #2426

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Aug 23, 2024

Rationale

If pcolor/pcolormesh receives shading=None, that should be treated the same as if shading was not set. My colleague was using pyplot.pcolormesh on a geoaxes, and pyplot explicitly defaults the shading to None. This caused a hard-to-debug artefact!

Implications

@dopplershift dopplershift merged commit 75939f9 into SciTools:main Aug 23, 2024
21 checks passed
@rcomer
Copy link
Member Author

rcomer commented Aug 23, 2024

Thanks @dopplershift!

@rcomer rcomer deleted the pcolormesh-shading branch August 23, 2024 16:59
@rcomer rcomer added this to the Next Release milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants