Improve matrixing in GHA to work with SciTools/cartopy#2303 #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
Jan 11, 2024
QuLogic
previously requested changes
Jan 11, 2024
greglucas
approved these changes
Feb 14, 2024
greglucas
dismissed
QuLogic’s stale review
This has been included in a recent push
|
Thanks, people! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
When a test fails, image results are uploaded. Since
actions/upload-artifact@v4(#2303), it is the responsibility of the workflow YAML file to avoid name clashes in the artifacts. This PR makes sure that the whole matrix is included in the artifact name and path, avoiding clashes betweenmatrix.shapely-devtruevsfalse.Implications
Failures for
ubuntu-latest, latest python will not result in one of the image uploads failing due to a name clash with the other.