Preset Stamen tile file extension, opacity #2202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgolston
changed the title
|
The initial commit ignored the optional desired_tile_form input parameter, which is now fixed. I believe the code is ready for review. |
Co-authored-by: Ryan May <rmay31@gmail.com>
dopplershift
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
In issue #2198 it was pointed out the Stamen watercolor tiles can not be downloaded currently as png. Right now, all the layers are downloaded as png and also default to RGB mode. This PR creates a dictionary to set the file extension automatically (specifically using jpg for watercolor) and desired_tile_form to RGBA for known layers which should have a transparent background (like terrain-lines).
Implications
Stamen watercolor feature should be working again, and behavior of behavior of non-opaque layers improved. By explicitly listing the known Stamen layers in a dict, this also may help the user be aware of the available options.