Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass 'keep' instead of '' in AxesGrid example #2196

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

lgolston
Copy link
Contributor

Rationale

The miscellanea/axes_grid_basic now throws a matplotlib deprecation warning due to an undefined label_mode. This updated to 'keep' according to https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.7.0.html#passing-undefined-label-mode-to-grid

Copy link
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lgolston!

@greglucas greglucas merged commit f8d69dd into SciTools:main Jun 23, 2023
@greglucas greglucas added this to the 0.22 milestone Jun 23, 2023
@lgolston lgolston deleted the label-mode-deprec branch June 25, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants