add ci manifest check #2154
Merged
add ci manifest check #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjlittle
commented
Mar 13, 2023
Comment on lines
+13
to
+18
| "lib/cartopy/_version.py", | ||
| "lib/cartopy/trace.cpp", |
There was a problem hiding this comment.
Note that, these files are present in the sdist, but are not under version control, therefore require to be ignored otherwise the check-manifest will rightly complain that there is a mismatch.
bjlittle
force-pushed
the
check-manifest
branch
from
790df0c
to
1c39427
Compare
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
@dopplershift Conflicts resolved 👍 |
dopplershift
approved these changes
Mar 13, 2023
|
🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GHA workflow to ensure that the
MANIFEST.inreconciles with the contents of thesdistusing check-manifest.This should give us continued confidence that the
sdistand binarywheelscontain all the necessary payload forcartopyon PyPI.Reference: Including files in source distributions with
MANIFEST.in