-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: add omerc to projections list #2146
Conversation
@@ -60,7 +59,7 @@ AzimuthalEquidistant | |||
import matplotlib.pyplot as plt | |||
import cartopy.crs as ccrs | |||
|
|||
plt.figure(figsize=(3, 3)) | |||
plt.figure(figsize=(3.0101, 3)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did this value come from? Seems like it was OK on the current docs: https://scitools.org.uk/cartopy/docs/latest/reference/projections.html#azimuthalequidistant
Same with the Orthographic update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Struck me as kinda odd too.
I simply done a make projection
and this is the automated change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want me to revert that particular auto-change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, the width is taken from the x_limits
of each projection, so my guess is this has to do with PROJ updating some of their limits with a version bump at some point...
@bjlittle looks like this one didn't run the pre-commit.ci on the PR since it was in beforehand. Can you also fix the end-of-file in your upcoming PR? Might be a little more work and require a trailing newline in the |
Awesome, thanks @greglucas |
This PR is a follow-up to #2096.
See this comment.