-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image tests #2058
Fix image tests #2058
Conversation
Could not review pull request. It may be too large, or contain no reviewable changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inline_usa
images are supposed to skipped. They hit the pytest.skip()
call, but pytest-mpl still compares the images even though it was skipped. I think this is likely a recent update on the pytest-mpl side. I guess I'd suggest we don't add the images and raise an issue upstream for them to fix that use-case.
Ah, I see it now. I'll force |
284c145
to
7a835c3
Compare
7a835c3
to
a8f3c15
Compare
These only minimally changed with a shifting of the dashes in the gridlines, but no substantive changes.
This version has a bug where it ignores our skip in some parametrized tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. This needs a rebase now that the other PR went in first. Feel free to self-merge once the conflicts are fixed.
a8f3c15
to
b67b269
Compare
This is fixing failing image tests in CI.
* We apparently had some missing images in the parametrized tests (Parametrize inline gridliner tests #1900) that pytest-mpl is now complaining about. I have no idea if these are actually correct, but they're the current behavior.pytest-mpl!=0.16.0
Alternatively for the second problem, if anyone knows if the projections make absolutely no sense for the US domain, we could just remove them from the list for that test.