Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Change testing method for tolerances #2056

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

greglucas
Copy link
Contributor

Change to assert_allclose instead of assert_almost_equal to test
small changes as recommended by Numpy's testing docs. This is due
to small tolerance changes with PROJ 9.0.1.

closes #2051

Change to assert_allclose instead of assert_almost_equal to test
small changes as recommended by Numpy's testing docs. This is due
to small tolerance changes with PROJ 9.0.1.
@dopplershift
Copy link
Contributor

The changes seem fine, but it's failing a bunch of things for...reasons.

Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with merging this and fixing the image tests in a separate PR.

@QuLogic QuLogic merged commit 328dc03 into SciTools:main Jun 28, 2022
@QuLogic QuLogic modified the milestones: 0.21, 0.20.3 Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures with PROJ 9.0.1
3 participants