-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: GH #2013 make regrid arguments, docstring consistent #2014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I think this has little chance of impacting people downstream and isn't worth doing a lot of deprecation dance around.
I agree, my only concern is the test failures, which I've not had a chance to dig into to see if they're related. |
I've been confused by this one, but I get an identical error (cartopy.tests.test_shapereader.TestLakes) when testing the head branch on my computer, so it doesn't seem to be due to any of these changes. |
Yes, that looks like the same error as here: #2012 |
Thanks, @ellequelle! |
Rationale
Addresses #2013
Implications
This is a change to the API for
img_transform.regrid
I changed the name of the 4th argument from
source_cs
tosource_proj
to be consistent with other argument names. It's probably uncommon for source projection object to be passed as a keyword argument since it's the fourth of six positional arguments.Old function signature:
cartopy/lib/cartopy/img_transform.py
Lines 222 to 223 in 22cdafc
New function signature: