Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrize inline gridliner tests #1900

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Parametrize inline gridliner tests #1900

merged 2 commits into from
Oct 7, 2021

Commits on Oct 7, 2021

  1. Parametrize inline gridliner tests 

    Unlike the old `ImageTesting` decorator, pytest-mpl support parametrized
tests. While this does add a bunch of new tests/images, they are all far
smaller than the single test, and can be run in parallel.

Since they are all generated anew, I switched to the new mpl20 style.
Besides the style, I believe this causes the following changes to
gridline locations for inline:

- EuroPP labels are half the tick interval as before
- OSNI labels latitude every 0.5° instead of every 1°

and for inline USA:

- InterruptedGoodeHomolosine labels longitude every 10° instead of
  every 20°
- LambertConformal labels longitude every 10° instead of every 20°
- NorthPolarStereo labels latitude every 5° instead of every 10°
- Robinson labels longitude every 10° instead of every 20°
- Stereographic labels longitude every 10° instead of every 20°

The automatic display of labels has a few small differences in the
inline results, probably due to different Axes size:

- Geostationary labels 20°W and 40°E instead of 0°
- LambertAzimuthalEqualArea also labels 30°N/30°S somehow
- LambertConformal also labels the inner 60°W
- NearsidePerspective labels 40°E instead of 60°E
- Orthographic also labels 0° longitude
- OSGB also labels 6°W and 2°W on the top, and 4°W on the bottom
- Robinson also labels 60°W

For the inline USA results, there are fewer differences:

- AzimuthalEquidistant also labels 60°N, but somewhat poorly
- EuroPP, OSGB, and OSNI are skipped since their extent is locked
- Geostationary also labels 60°W on the bottom
- Gnomonic also labels 68°W
- NearsidePerspective also labels 60°W on the bottom
- Orthographic also labels 70°W on the bottom
    @QuLogic
    QuLogic committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    2ad6706 View commit details
    Browse the repository at this point in the history

  2. Tweak tight gridliner test tolerance 

    Tis fixes test on minimum Matplotlib
    @QuLogic
    QuLogic committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    f1f6453 View commit details
    Browse the repository at this point in the history