Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrame#vectors= should change the name of the vectors in @data. #293

Merged
merged 2 commits into from
Jan 28, 2017

Conversation

genya0407
Copy link
Contributor

DataFrame#vectors= changes @vectors variable, however, the name of the vectors in @data is not changed.

irb(main):002:0> df = Daru::DataFrame.new(a: [1,2,3])
=> #<Daru::DataFrame(3x1)>
       a
   0   1
   1   2
   2   3
irb(main):004:0> df.vectors = Daru::Index.new [:b]
irb(main):005:0> df
=> #<Daru::DataFrame(3x1)>
       b
   0   1
   1   2
   2   3
irb(main):006:0> df[:b]
=> #<Daru::Vector(3)>
       a
   0   1
   1   2
   2   3

DataFrame#vectors= should change the name of vectors in @data.

@v0dro
Copy link
Member

v0dro commented Jan 12, 2017

@genya0407 can you please rebase with the current master?

@v0dro v0dro merged commit cedab19 into SciRuby:master Jan 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants