Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve graph workflow, add better support for local LLMs #1803

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Jan 10, 2025

Important

Improve graph workflow by removing GraphExtractionPipe and updating logic for XML-based entity and relationship extraction, enhancing local LLM support.

  • Graph Workflow Improvements:
    • Remove GraphExtractionPipe and related logic from graph_service.py and factory.py.
    • Update kg_extraction() in graph_service.py to use XML for entity and relationship extraction.
    • Modify process_community() in community_summary.py to handle XML responses.
  • Local LLM Support:
    • Update graphrag_relationships_extraction_few_shot.yaml to use XML format for entity and relationship extraction.
    • Modify graphrag_communities.yaml to use XML format for community reports.
  • Miscellaneous:
    • Remove GraphExtractionPipe from __init__.py and abstractions.py.
    • Remove unused imports and functions related to GraphExtractionPipe.

This description was created by Ellipsis for 610abb8. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 610abb8 in 1 minute and 51 seconds

More details
  • Looked at 1283 lines of code in 11 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. py/core/__init__.py:213
  • Draft comment:
    The GraphExtractionPipe has been removed from the imports. Ensure that this change is reflected in any documentation or references to this pipe.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The removal of the GraphExtractionPipe from the imports and the codebase indicates a significant change in the architecture. This should be noted for future reference and documentation updates.
2. py/core/main/abstractions.py:14
  • Draft comment:
    The GraphExtractionPipe has been removed from the imports. Ensure that this change is reflected in any documentation or references to this pipe.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The removal of the GraphExtractionPipe from the imports and the codebase indicates a significant change in the architecture. This should be noted for future reference and documentation updates.
3. py/core/main/assembly/factory.py:25
  • Draft comment:
    The GraphExtractionPipe has been removed from the imports. Ensure that this change is reflected in any documentation or references to this pipe.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The removal of the GraphExtractionPipe from the imports and the codebase indicates a significant change in the architecture. This should be noted for future reference and documentation updates.
4. py/core/pipes/__init__.py:23
  • Draft comment:
    The GraphExtractionPipe has been removed from the imports. Ensure that this change is reflected in any documentation or references to this pipe.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The removal of the GraphExtractionPipe from the imports and the codebase indicates a significant change in the architecture. This should be noted for future reference and documentation updates.
5. py/core/main/services/graph_service.py:69
  • Draft comment:
    The GraphExtractionPipe has been removed from the imports. Ensure that this change is reflected in any documentation or references to this pipe.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The removal of the GraphExtractionPipe from the imports and the codebase indicates a significant change in the architecture. This should be noted for future reference and documentation updates.

Workflow ID: wflow_cJzuzVvugN6DxY3k


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit dff76c5 into main Jan 11, 2025
13 of 14 checks passed
@NolanTrem NolanTrem deleted the Nolan/XMLGraphs branch January 11, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant