Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up #1801

Merged
Merged

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Jan 10, 2025

Important

Adds collection usage tracking to get_all_user_limits() in management_service.py.

  • Behavior:
    • Adds tracking for collection usage in get_all_user_limits() in management_service.py.
    • Calculates max_collections, used_collections, and remaining collections.
  • Functions:
    • Calls get_user_max_collections() to get the maximum collections limit.
    • Calls get_collections_overview() to determine used collections.

This description was created by Ellipsis for 81017bf. It will automatically update as commits are pushed.

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review January 10, 2025 17:59
@emrgnt-cmplxty emrgnt-cmplxty merged commit 4b85255 into main Jan 10, 2025
2 of 3 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 81017bf in 18 seconds

More details
  • Looked at 31 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/core/main/services/management_service.py:1086
  • Draft comment:
    Ensure max_collections and used_collections are not None before performing subtraction to avoid TypeError.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_9PL49LtOWodRUvjQ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant