Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix oauth collection bug #1799

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Jan 10, 2025

Important

Fixes OAuth user registration bug by ensuring consistent user creation logic in r2r_auth.py.

  • Behavior:
    • Fixes bug in register() in r2r_auth.py by ensuring new_user is fully populated after creation.
    • Refactors oauth_callback_handler() in r2r_auth.py to use register() for user creation, ensuring consistent user creation logic.
  • Misc:
    • Removes redundant user creation code in oauth_callback_handler() for Google and GitHub providers.

This description was created by Ellipsis for 4eb13f2. It will automatically update as commits are pushed.

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review January 10, 2025 17:49
@emrgnt-cmplxty emrgnt-cmplxty merged commit 7f89da3 into main Jan 10, 2025
3 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 4eb13f2 in 13 seconds

More details
  • Looked at 57 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/core/providers/auth/r2r_auth.py:611
  • Draft comment:
    Using register instead of create_user ensures consistent user creation logic and handles email verification if required. This change is beneficial for maintaining uniformity in user registration processes.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The PR changes the way new users are created during OAuth callback handling by using the register method instead of create_user. This ensures consistent user creation logic and handles email verification if required.

Workflow ID: wflow_wd1ciZai1FKYghX3


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant