Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding auto-gen email fallback for github oauth #1798

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Jan 10, 2025

Important

Adds fallback email generation for GitHub and Google OAuth in users_router.py when email is not provided.

  • Behavior:
    • Adds fallback email generation in google_callback() and github_callback() in users_router.py.
    • Uses format {oauth_id}@google_oauth.fake and {github_id}@github_oauth.fake if email is not provided by the OAuth provider.

This description was created by Ellipsis for bd861d2. It will automatically update as commits are pushed.

@emrgnt-cmplxty emrgnt-cmplxty changed the title up Adding auto-gen email fallback for github oauth Jan 10, 2025
@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review January 10, 2025 03:56
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to bd861d2 in 10 seconds

More details
  • Looked at 27 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/core/main/api/v3/users_router.py:1905
  • Draft comment:
    Consider documenting the use of the fake email domain or ensuring it doesn't conflict with email validation or uniqueness constraints.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR introduces a fallback email for GitHub OAuth when the email is not provided. This is a good practice to ensure that the system can handle cases where the email is private or not available. However, the use of a fake email domain should be documented or handled carefully to avoid any potential issues with email validation or uniqueness constraints in the database.

Workflow ID: wflow_JPmXk7WH3wLh3GkS


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@emrgnt-cmplxty emrgnt-cmplxty merged commit 5810cb6 into main Jan 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant