Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Gemini #1794

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add support for Gemini #1794

merged 1 commit into from
Jan 10, 2025

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Jan 10, 2025

Important

Add support for Google Gemini by introducing GEMINI_API_KEY in Docker Compose files and make minor code cleanups.

  • Environment Variables:
    • Add GEMINI_API_KEY to compose.yaml, compose.full.yaml, and compose.full_with_replicas.yaml for Google Gemini support.
  • Misc:
    • Remove unused print statement in users_router.py.
    • Add missing comma in function calls across multiple files for consistency.

This description was created by Ellipsis for 52e5bd6. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 52e5bd6 in 27 seconds

More details
  • Looked at 260 lines of code in 11 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/r2r/compose.full.yaml:332
  • Draft comment:
    Added GEMINI_API_KEY environment variable for Google Gemini support. Ensure this key is set in your environment to enable Gemini features.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The PR adds support for Google Gemini by introducing a new environment variable GEMINI_API_KEY in the Docker Compose files. This is a straightforward addition and seems consistent across all the relevant files.

Workflow ID: wflow_fXj2eu08O9Mhkiq0


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit c1fe474 into main Jan 10, 2025
14 checks passed
@NolanTrem NolanTrem deleted the Nolan/GeminiKey branch January 10, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant