Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ingestion #1785

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix ingestion #1785

merged 2 commits into from
Jan 8, 2025

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Jan 8, 2025

Important

Fixes current_usage initialization in vector_storage_pipe.py to ensure correct usage calculation per message.

  • Behavior:
    • Fixes current_usage initialization in _run_logic() in vector_storage_pipe.py to occur inside the loop, ensuring correct usage calculation per message.
    • Assumes only one owner per message for current_usage calculation.
  • Logging:
    • Logs error if user exceeds maximum allowed chunks in _run_logic() in vector_storage_pipe.py.

This description was created by Ellipsis for 6092ad8. It will automatically update as commits are pushed.

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review January 8, 2025 23:12
@emrgnt-cmplxty emrgnt-cmplxty merged commit e8a49dd into main Jan 8, 2025
13 of 14 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6092ad8 in 9 seconds

More details
  • Looked at 29 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/core/pipes/ingestion/vector_storage_pipe.py:68
  • Draft comment:
    The current_usage check and assignment can be moved outside the loop since it only needs to be set once per message batch. This will make the code cleaner and more efficient.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The current_usage variable is being set inside the loop but only once, which is correct given the assumption of one owner per message. However, the logic for checking and setting current_usage can be optimized.

Workflow ID: wflow_yz5BYtCcyXlFKRsy


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant