Feature/fix password reset js sdk #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 5965987 in 35 seconds
More details
- Looked at
54lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_hcJrzUG6Tn0WnM9N
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| async requestPasswordReset(options: { | ||
| email: string; | ||
| }): Promise<WrappedGenericMessageResponse> { | ||
| async requestPasswordReset(email: string): Promise<WrappedGenericMessageResponse> { |
There was a problem hiding this comment.
Consider using an options object for the requestPasswordReset method to maintain consistency with other methods in the class.
Suggested change
| async requestPasswordReset(email: string): Promise<WrappedGenericMessageResponse> { | |
| async requestPasswordReset(options: { email: string }): Promise<WrappedGenericMessageResponse> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Updates
requestPasswordResetinusers.tsto accept a string email and bumps version inpackage.json.requestPasswordResetinusers.tsnow accepts a string email instead of an object.Content-Typeheader totext/plaininrequestPasswordReset.package.jsonfrom0.4.11to0.4.12.This description was created by
for 5965987. It will automatically update as commits are pushed.