Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only log POST and DELETE requests in the request_log table #1781

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Jan 8, 2025

Important

Modify rate_limit_dependency in base_router.py to log only POST and DELETE requests, skipping others.

  • Behavior:
    • Modify rate_limit_dependency in base_router.py to log only POST and DELETE requests.
    • Skips logging for other HTTP methods, optimizing database operations.

This description was created by Ellipsis for 28ef06b. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 28ef06b in 7 seconds

More details
  • Looked at 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/core/main/api/v3/base_router.py:155
  • Draft comment:
    Consider adding a comment explaining why only POST and DELETE requests are logged for future maintainability.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The change to log only POST and DELETE requests is correctly implemented, but it might be beneficial to add a comment explaining why only these methods are logged for future reference.

Workflow ID: wflow_CQTtzMviNBHX97GA


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit 1eee23c into main Jan 8, 2025
14 checks passed
@NolanTrem NolanTrem deleted the Nolan/RequestLogging branch January 8, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant