Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on pyproject.toml in site package #1777

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Jan 8, 2025

Important

Replaces pyproject.toml version retrieval with importlib.metadata.version, removes debug prints, and improves code formatting.

  • Version Retrieval:
    • Replaces pyproject.toml version retrieval with importlib.metadata.version("r2r") in ProductTelemetryClient in telemetry_decorator.py and __init__.py in r2r.
  • Debug Statements:
    • Removes debug print statements from create_user_api_key in users_router.py.
  • Code Formatting:
    • Uses textwrap.dedent for code samples in get_user_limits in users_router.py.

This description was created by Ellipsis for 68f9fd9. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 4770f12 in 1 minute and 3 seconds

More details
  • Looked at 119 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/core/telemetry/telemetry_decorator.py:30
  • Draft comment:
    The error message still references 'pyproject.toml', which is no longer used. Update the message to reflect the new version retrieval method.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_JUAVxlc1JB5dhwFi


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 57acfce in 51 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/pyproject.toml:28
  • Draft comment:
    The package_data entry for r2r is redundant since the include section already specifies the files to be included. Consider removing it to avoid confusion.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment appears to be incorrect. The include section at the top level is for project-level files, while package_data is specifically for files that should be included within the r2r package installation. These serve different purposes - one is for project structure, the other is for package distribution. The patterns are also different - one lists specific files, the other uses wildcards.
    I might be missing some Poetry-specific behavior where these sections interact in ways that aren't obvious from the file alone.
    Even if there are subtle interactions, the sections clearly serve different purposes and have different patterns, so the comment's claim of redundancy is not well-supported.
    Delete this comment as it appears to be incorrect - the sections serve different purposes and are not redundant.

Workflow ID: wflow_BnFqG9S4XiKWrho2


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 84c2a34 in 20 seconds

More details
  • Looked at 23 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/pyproject.toml:29
  • Draft comment:
    Removing package_data might lead to YAML and TOML files not being included in the package distribution. Ensure these files are not required at runtime or include them using another method.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_qBX2ZW54cM4iCgc8


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit 877899c into main Jan 8, 2025
3 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 68f9fd9 in 13 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/pyproject.toml:8
  • Draft comment:
    The version update from 3.3.22 to 3.3.23 is consistent with the changes in version retrieval mentioned in the PR description. Ensure that all relevant documentation and release notes are updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The change in version number from 3.3.22 to 3.3.23 is consistent with the PR description, which mentions version retrieval changes. This is a minor version update, likely due to the internal changes in how the version is retrieved.

Workflow ID: wflow_5SmhHdWCzfgMvnKN


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem deleted the Nolan/SitePackage branch January 8, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant