-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on pyproject.toml in site package #1777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 4770f12 in 1 minute and 3 seconds
More details
- Looked at
119
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. py/core/telemetry/telemetry_decorator.py:30
- Draft comment:
The error message still references 'pyproject.toml', which is no longer used. Update the message to reflect the new version retrieval method. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_JUAVxlc1JB5dhwFi
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 57acfce in 51 seconds
More details
- Looked at
12
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. py/pyproject.toml:28
- Draft comment:
Thepackage_data
entry forr2r
is redundant since theinclude
section already specifies the files to be included. Consider removing it to avoid confusion. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment appears to be incorrect. Theinclude
section at the top level is for project-level files, whilepackage_data
is specifically for files that should be included within the r2r package installation. These serve different purposes - one is for project structure, the other is for package distribution. The patterns are also different - one lists specific files, the other uses wildcards.
I might be missing some Poetry-specific behavior where these sections interact in ways that aren't obvious from the file alone.
Even if there are subtle interactions, the sections clearly serve different purposes and have different patterns, so the comment's claim of redundancy is not well-supported.
Delete this comment as it appears to be incorrect - the sections serve different purposes and are not redundant.
Workflow ID: wflow_BnFqG9S4XiKWrho2
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 84c2a34 in 20 seconds
More details
- Looked at
23
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. py/pyproject.toml:29
- Draft comment:
Removingpackage_data
might lead to YAML and TOML files not being included in the package distribution. Ensure these files are not required at runtime or include them using another method. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_qBX2ZW54cM4iCgc8
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 68f9fd9 in 13 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. py/pyproject.toml:8
- Draft comment:
The version update from 3.3.22 to 3.3.23 is consistent with the changes in version retrieval mentioned in the PR description. Ensure that all relevant documentation and release notes are updated accordingly. - Reason this comment was not posted:
Confidence changes required:10%
The change in version number from 3.3.22 to 3.3.23 is consistent with the PR description, which mentions version retrieval changes. This is a minor version update, likely due to the internal changes in how the version is retrieved.
Workflow ID: wflow_5SmhHdWCzfgMvnKN
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Replaces
pyproject.toml
version retrieval withimportlib.metadata.version
, removes debug prints, and improves code formatting.pyproject.toml
version retrieval withimportlib.metadata.version("r2r")
inProductTelemetryClient
intelemetry_decorator.py
and__init__.py
inr2r
.print
statements fromcreate_user_api_key
inusers_router.py
.textwrap.dedent
for code samples inget_user_limits
inusers_router.py
.This description was created by for 68f9fd9. It will automatically update as commits are pushed.