Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add R2R_SECRET_KEY and missing import #1772

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Add R2R_SECRET_KEY and missing import #1772

merged 2 commits into from
Jan 8, 2025

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Jan 8, 2025

Important

Add R2R_SECRET_KEY to Docker Compose files and fix aiofiles dependency in pyproject.toml.

  • Environment Variables:
    • Add R2R_SECRET_KEY to compose.full.yaml, compose.full_with_replicas.yaml, and compose.yaml.
  • Dependencies:
    • Move aiofiles from ingestion-bundle to main dependencies in pyproject.toml.

This description was created by Ellipsis for bf737d4. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 4812824 in 16 seconds

More details
  • Looked at 67 lines of code in 4 files
  • Skipped 1 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. py/compose.full.yaml:303
  • Draft comment:
    Ensure that R2R_SECRET_KEY is set securely in production environments to avoid potential security risks.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The addition of R2R_SECRET_KEY is consistent across all YAML files, which is good for consistency. However, the default value is empty, which might not be secure if the key is required for sensitive operations.
2. py/compose.full_with_replicas.yaml:301
  • Draft comment:
    Ensure that R2R_SECRET_KEY is set securely in production environments to avoid potential security risks.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The addition of R2R_SECRET_KEY is consistent across all YAML files, which is good for consistency. However, the default value is empty, which might not be secure if the key is required for sensitive operations.
3. py/compose.yaml:59
  • Draft comment:
    Ensure that R2R_SECRET_KEY is set securely in production environments to avoid potential security risks.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The addition of R2R_SECRET_KEY is consistent across all YAML files, which is good for consistency. However, the default value is empty, which might not be secure if the key is required for sensitive operations.
4. py/pyproject.toml:33
  • Draft comment:
    Remove the duplicate aiofiles entry in the dependencies section to avoid redundancy.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_G4N8GBzfLv3f0onC


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit e9fc549 into main Jan 8, 2025
2 of 3 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on bf737d4 in 10 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_QSzL8b8CEnLEnSQB


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem deleted the Nolan/R2R_SECRET_KEY branch January 8, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant