RFC 5987 Encoding on content-disposition headers

[NolanTrem]

Important

Update Content-Disposition headers to use RFC 5987 encoding for filenames in export_files and get_document_file.

• Behavior:
  • Update Content-Disposition header to use RFC 5987 encoding for filenames in export_files and get_document_file.
  • Encode filenames using urllib.parse.quote to handle special characters.
• Functions:
  • Modify export_files to set Content-Disposition with filename*=UTF-8''{encoded_filename}.
  • Modify get_document_file to set Content-Disposition with filename*=UTF-8''{encoded_filename}.

^{This description was created by for d28b645. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to d28b645 in 21 seconds

More details

• Looked at 46 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. py/core/main/api/v3/documents_router.py:766

• Draft comment:
  Consider checking if zip_name is ASCII and using filename instead of filename* for ASCII names to simplify the header.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR introduces RFC 5987 encoding for filenames in Content-Disposition headers. This is a good practice for handling non-ASCII characters in filenames. However, the PR does not handle the case where the filename might already be ASCII, which could be optimized by using the simpler 'filename' parameter instead of 'filename*'.

2. py/core/main/api/v3/documents_router.py:1263

• Draft comment:
  Consider checking if file_name is ASCII and using filename instead of filename* for ASCII names to simplify the header.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR introduces RFC 5987 encoding for filenames in Content-Disposition headers. This is a good practice for handling non-ASCII characters in filenames. However, the PR does not handle the case where the filename might already be ASCII, which could be optimized by using the simpler 'filename' parameter instead of 'filename*'.

Workflow ID: wflow_p15cAlQShNgeIer8

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.