Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI auth error message, move backoff down to 3 retries #1759

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Jan 6, 2025

Important

Update CLI auth error message, reduce retry count, and change default base URL and API version.

  • Behavior:
    • Update authentication error message in _auth_wrapper() in auth.py to provide more guidance on setting API key or changing base URL.
    • Reduce max_retries from 8 to 3 in EmbeddingConfig in embedding.py and CompletionConfig in llm.py.
    • Change default base_url to http://localhost:7272 in reset() in config.py.
    • Update API version prefix from /v2 to /v3 in async_client.py and base_client.py.
  • Configuration:
    • Add graph_clustering service with health check in compose.full.yaml.
  • Misc:
    • Increment version to 3.3.20 in pyproject.toml.

This description was created by Ellipsis for 9658811. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9658811 in 41 seconds

More details
  • Looked at 150 lines of code in 9 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. py/cli/commands/config.py:74
  • Draft comment:
    Changing the base URL from 'https' to 'http' can introduce security risks if used in a production environment. Ensure this change is intended for local development only.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. py/sdk/async_client.py:32
  • Draft comment:
    Updated API version from 'v2' to 'v3'. Ensure that all endpoints and services are compatible with the new version.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from version 'v2' to 'v3' in the async client and base client is consistent across the files, indicating an API version update.
3. py/sdk/base/base_client.py:39
  • Draft comment:
    Updated API version from 'v2' to 'v3'. Ensure that all endpoints and services are compatible with the new version.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from version 'v2' to 'v3' in the async client and base client is consistent across the files, indicating an API version update.
4. py/core/base/providers/embedding.py:33
  • Draft comment:
    Reduced max_retries from 8 to 3. Ensure this change aligns with the desired retry policy and doesn't affect the robustness of the retry mechanism.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The reduction of max_retries from 8 to 3 in both embedding and llm providers is a significant change that could affect the robustness of the retry mechanism.
5. py/core/base/providers/llm.py:26
  • Draft comment:
    Reduced max_retries from 8 to 3. Ensure this change aligns with the desired retry policy and doesn't affect the robustness of the retry mechanism.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The reduction of max_retries from 8 to 3 in both embedding and llm providers is a significant change that could affect the robustness of the retry mechanism.

Workflow ID: wflow_8FwQAdycmsnNncHL


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit c9d11c6 into main Jan 6, 2025
14 checks passed
@NolanTrem NolanTrem deleted the Nolan/CLIMessage branch January 6, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant