-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration script for user limits overrides #1755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 9047443 in 27 seconds
More details
- Looked at
339
lines of code in8
files - Skipped
0
files when reviewing. - Skipped posting
5
drafted comments based on config settings.
1. py/migrations/versions/2fac23e4d91b_migrate_to_document_search.py:188
- Draft comment:
Theoffset
is not being updated correctly in the loop. It should be incremented bylimit
instead of addinglimit
tooffset
. This will cause an infinite loop if the number of documents is greater than the limit.
offset += limit
- Reason this comment was not posted:
Comment was not on a valid diff hunk.
2. py/migrations/versions/7eb70560f406_add_limits_overrides_to_users.py:33
- Draft comment:
Avoid usingprint
statements in migration scripts. Consider using a logging framework instead for better control over output.
This comment also applies to similar print
statements in other migration scripts.
- Reason this comment was not posted:
Confidence changes required:50%
Thecheck_if_upgrade_needed
function inpy/migrations/versions/7eb70560f406_add_limits_overrides_to_users.py
and other migration scripts prints messages to the console. This is not a best practice for migration scripts as it can clutter the output. Consider using logging instead.
3. py/migrations/versions/8077140e1e99_v3_api_database_revision.py:44
- Draft comment:
Avoid usingprint
statements in migration scripts. Consider using a logging framework instead for better control over output.
This comment also applies to similar print
statements in other migration scripts.
- Reason this comment was not posted:
Confidence changes required:50%
Thecheck_if_upgrade_needed
function inpy/migrations/versions/8077140e1e99_v3_api_database_revision.py
and other migration scripts prints messages to the console. This is not a best practice for migration scripts as it can clutter the output. Consider using logging instead.
4. py/migrations/versions/c45a9cf6a8a4_add_user_and_document_count_to_.py:41
- Draft comment:
Avoid usingprint
statements in migration scripts. Consider using a logging framework instead for better control over output.
This comment also applies to similar print
statements in other migration scripts.
- Reason this comment was not posted:
Confidence changes required:50%
Thecheck_if_upgrade_needed
function inpy/migrations/versions/c45a9cf6a8a4_add_user_and_document_count_to_.py
and other migration scripts prints messages to the console. This is not a best practice for migration scripts as it can clutter the output. Consider using logging instead.
5. py/migrations/versions/d342e632358a_migrate_to_asyncpg.py:47
- Draft comment:
Avoid usingprint
statements in migration scripts. Consider using a logging framework instead for better control over output.
This comment also applies to similar print
statements in other migration scripts.
- Reason this comment was not posted:
Confidence changes required:50%
Thecheck_if_upgrade_needed
function inpy/migrations/versions/d342e632358a_migrate_to_asyncpg.py
and other migration scripts prints messages to the console. This is not a best practice for migration scripts as it can clutter the output. Consider using logging instead.
Workflow ID: wflow_k2zxU8wZlLvseBfn
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on be75154 in 11 seconds
More details
- Looked at
26
lines of code in2
files - Skipped
1
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. js/sdk/package.json:3
- Draft comment:
Ensure the version bump follows semantic versioning principles. Since a new feature is added, a minor version bump is appropriate. - Reason this comment was not posted:
Confidence changes required:50%
The version bump inpackage.json
andpyproject.toml
is consistent with the changes described in the PR. However, it's important to ensure that the versioning follows semantic versioning principles. Since the changes involve adding a new feature (migration script), a minor version bump is appropriate.
Workflow ID: wflow_FNoUIQcMSJCPVnw4
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 3126ed6 in 11 seconds
More details
- Looked at
14
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. py/compose.yaml:40
- Draft comment:
The Docker image for the 'r2r' service was reverted to 'ragtoriches/prod:latest', but the PR description indicates it should be 'r2r/test'. Please ensure the image is updated as intended. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_PnB8MOAXo7pIW2oe
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on e831245 in 9 seconds
More details
- Looked at
17
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. js/README.md:3
- Draft comment:
Ensure the updated link is correct and accessible. Verify thathttps://r2r-docs.sciphi.ai/api-and-sdks/introduction
is the intended URL. - Reason this comment was not posted:
Confidence changes required:50%
The updated links in the README file should be verified for correctness.
2. js/README.md:7
- Draft comment:
Ensure the updated link is correct and accessible. Verify thathttps://r2r-docs.sciphi.ai/documentation/installation/overview
is the intended URL. - Reason this comment was not posted:
Confidence changes required:50%
The updated links in the README file should be verified for correctness.
Workflow ID: wflow_iBSpc9mIRfuDFK96
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Add migration script for
limits_overrides
column inusers
table, update Docker image, and add CLI warning for older version upgrades.limits_overrides
column tousers
table in7eb70560f406_add_limits_overrides_to_users.py
.check_if_upgrade_needed()
to verify if migration is required.upgrade()
anddowngrade()
functions for migration.serve()
insystem.py
for users migrating from version 3.3.18 or earlier.r2r/test
incompose.yaml
.package.json
to0.4.8
.pyproject.toml
to3.3.19
.This description was created by for e831245. It will automatically update as commits are pushed.