Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert graph filters #1754

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Revert graph filters #1754

merged 1 commit into from
Jan 4, 2025

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Jan 4, 2025

Important

Reverts graph filter logic in graphs.py, removing apply_filters and reintroducing custom filter parsing in graph_search() and _build_filters().

  • Behavior:
    • Reverts graph filter logic in graph_search() and _build_filters() in graphs.py.
    • Removes apply_filters function usage, reintroducing custom filter parsing.
    • Handles $eq, $ne, $lt, $lte, $gt, $gte, $in, $contains operations in _build_filters().
  • Exceptions:
    • Removes UndefinedColumnError handling in graph_search().
    • Continues to handle general exceptions with HTTP 500 error in graph_search().

This description was created by Ellipsis for f349869. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f349869 in 2 minutes and 59 seconds

More details
  • Looked at 211 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. py/core/database/graphs.py:15
  • Draft comment:
    The import for apply_filters is removed, and _build_filters is re-implemented. This aligns with the PR's intent to revert graph filters.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The import statement for apply_filters is removed, but the function _build_filters is re-implemented in this PR. This change is consistent with the PR title 'Revert graph filters', indicating a reversion to a previous implementation. The removal of apply_filters is intentional and aligns with the PR's purpose.
2. py/core/database/graphs.py:2602
  • Draft comment:
    The exception handling for UndefinedColumnError is removed. Ensure this aligns with the intended error handling strategy.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The exception handling for UndefinedColumnError is removed, which might lead to unhandled exceptions if such an error occurs. This change should be reviewed to ensure it aligns with the intended behavior of the application.
3. py/core/database/graphs.py:2614
  • Draft comment:
    The _build_filters function is re-implemented. Review for correctness in handling various operators and data types.
  • Reason this comment was not posted:
    Confidence changes required: 40%
    The _build_filters function is re-implemented, and it includes a detailed parsing of filter conditions. This implementation should be reviewed for correctness and completeness, especially in handling various operators and data types.

Workflow ID: wflow_PbOS5bjMNb7kbEC6


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit 91719c1 into main Jan 4, 2025
14 checks passed
@NolanTrem NolanTrem deleted the Nolan/RevertGraphFilters branch January 4, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant