Fix filter logic bugs #1753
Fix filter logic bugs #1753
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 0002c0c in 2 minutes and 12 seconds
More details
- Looked at
628lines of code in4files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. py/core/database/filters.py:376
- Draft comment:
The_build_metadata_conditionmethod should handle cases wherevalis a list or dict for$eqand$neoperators, as these are not currently handled. - Reason this comment was not posted:
Comment was on unchanged code.
2. py/core/database/filters.py:170
-
Draft comment:
This function is identical to the existingpsql_quote_literal. Consider using that instead to avoid duplication. -
function
psql_quote_literal(chunks.py) -
Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_LQP9JtPTUtOYc7Cp
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| }, | ||
| }, | ||
| }), | ||
| ); |
There was a problem hiding this comment.
The test for filtering on a non-existent column is incomplete. It should check for an empty result set.
| detail=f"An error occurred while searching: {e}", | ||
| ) from e | ||
| except Exception as e: | ||
| raise HTTPException( |
There was a problem hiding this comment.
Catching a generic Exception and raising an HTTPException with a misleading message about updating an entity. This should be corrected to reflect the actual operation being performed.
Allows for better filtering, fixes a number of bugs around passing integers.
Fixes #1699
Important
Enhances filter logic and error handling for integer values and undefined columns, with new test cases and refactoring in filter-related modules.
filters.pyandgraphs.py.DocumentsIntegrationSuperUser.test.tsto verify filter operations like$lte,$gte,$eq, and range filters.graph_search()ingraphs.py.filters.py.filters.pyandgraphs.py.search.pyto streamline filter selection logic.This description was created by
for 0002c0c. It will automatically update as commits are pushed.