Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Hatchet step timeouts #1750

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Increase Hatchet step timeouts #1750

merged 1 commit into from
Jan 3, 2025

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Jan 3, 2025

Important

Increased timeout settings for Hatchet workflows and improved exception handling in ingestion_workflow.py and kg_workflow.py.

  • Timeout Adjustments:
    • Increased timeout for kg-extract workflow to 360m in kg_workflow.py.
    • Increased timeout for extract-triples workflow to 360m in kg_workflow.py.
    • Increased timeout for build-communities workflow to 360m in kg_workflow.py.
    • Increased timeout for create-vector-index step to 360m in ingestion_workflow.py.
    • Increased timeout for delete-vector-index step to 30m in ingestion_workflow.py.
  • Code Improvements:
    • Simplified conditional check in on_failure() in ingestion_workflow.py.
    • Used contextlib.suppress for exception handling in kg_workflow.py.

This description was created by Ellipsis for e65b4cf. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e65b4cf in 1 minute and 52 seconds

More details
  • Looked at 210 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. py/core/main/orchestration/hatchet/ingestion_workflow.py:596
  • Draft comment:
    The PR title suggests an increase in Hatchet step timeouts, but the changes in this file do not reflect that intent. Ensure that the timeouts are updated as intended.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. py/core/main/orchestration/hatchet/kg_workflow.py:105
  • Draft comment:
    The PR title suggests an increase in Hatchet step timeouts, but the changes in this file do not reflect that intent. Ensure that the timeouts are updated as intended.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_5I79utS3riOpFkhy


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit 7a7f25f into main Jan 3, 2025
13 of 14 checks passed
@NolanTrem NolanTrem deleted the Nolan/HatchetTimeout branch January 3, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant