Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing to StoreType #1745

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Add typing to StoreType #1745

merged 1 commit into from
Dec 31, 2024

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Dec 31, 2024

Important

Refactor StoreType usage by moving its definition to graph.py and updating imports across the codebase, while removing unused telemetry event classes.

  • Refactoring:
    • Move StoreType from graphs.py to graph.py.
    • Update imports for StoreType in documents_router.py, graph_router.py, graph_service.py, and management_service.py.
  • Code Cleanup:
    • Remove StoreType definition from graphs.py.
    • Remove unused telemetry event classes from events.py.

This description was created by Ellipsis for 99ba3c0. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 99ba3c0 in 55 seconds

More details
  • Looked at 479 lines of code in 10 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/shared/abstractions/graph.py:140
  • Draft comment:
    The StoreType enum is correctly defined here and used consistently across the codebase. This change improves type safety and clarity.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR introduces a new enum StoreType in py/shared/abstractions/graph.py and removes its previous definition from py/core/database/graphs.py. This change is consistent across the codebase, as seen in the imports and usage in various files. The enum is used to specify the type of storage, either GRAPHS or DOCUMENTS. The change is correctly reflected in the imports and usage across the codebase, ensuring type safety and clarity.

Workflow ID: wflow_gbnIm7q4pBcomfYR


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit f331bfa into main Dec 31, 2024
13 of 14 checks passed
@NolanTrem NolanTrem deleted the Nolan/StoreType branch December 31, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant