Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved typing, Remove old methods #1743

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Improved typing, Remove old methods #1743

merged 1 commit into from
Dec 31, 2024

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Dec 31, 2024

Important

Improve type annotations and remove deprecated methods in main.py, ingestion.py, and users.py.

  • Typing Improvements:
    • Change Dict to dict in save_config() in main.py.
    • Change List to list in get_all_users() in users.py.
  • Method Removal:
    • Remove duplicate get_default() and set_default() methods in ingestion.py.

This description was created by Ellipsis for 3a10484. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 3a10484 in 15 seconds

More details
  • Looked at 79 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. py/cli/main.py:2
  • Draft comment:
    Consider using dict instead of Dict for consistency with other changes in this PR.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes typing from Dict and List to dict and list, which is a valid change in Python 3.9+ but should be consistent across the codebase.
2. py/core/database/users.py:3
  • Draft comment:
    Consider using dict and list instead of Dict and List for consistency with other changes in this PR.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes typing from Dict and List to dict and list, which is a valid change in Python 3.9+ but should be consistent across the codebase.

Workflow ID: wflow_1IL3xovkd6gzkKsm


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit 39322c9 into main Dec 31, 2024
13 of 14 checks passed
@NolanTrem NolanTrem deleted the Nolan/Linting branch December 31, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant