-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export Functionality #1740
Merged
Merged
Export Functionality #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to b1af2de in 1 minute and 15 seconds
More details
- Looked at
5167
lines of code in35
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. py/sdk/v3/conversations.py:201
- Draft comment:
Theexport
andexport_messages
methods have similar logic. Consider refactoring to use a helper function to reduce redundancy. - Reason this comment was not posted:
Confidence changes required:50%
The code in theexport
andexport_messages
methods inpy/sdk/v3/conversations.py
andpy/sdk/v3/documents.py
is almost identical. This redundancy can be reduced by creating a helper function to handle the common logic, which will improve maintainability and reduce the risk of errors.
2. py/sdk/v3/documents.py:196
- Draft comment:
Theexport
andexport_entities
methods have similar logic. Consider refactoring to use a helper function to reduce redundancy. - Reason this comment was not posted:
Confidence changes required:50%
The code in theexport
andexport_entities
methods inpy/sdk/v3/documents.py
is almost identical. This redundancy can be reduced by creating a helper function to handle the common logic, which will improve maintainability and reduce the risk of errors.
3. py/sdk/v3/documents.py:293
- Draft comment:
Theexport
andexport_relationships
methods have similar logic. Consider refactoring to use a helper function to reduce redundancy. - Reason this comment was not posted:
Confidence changes required:50%
The code in theexport
andexport_relationships
methods inpy/sdk/v3/documents.py
is almost identical. This redundancy can be reduced by creating a helper function to handle the common logic, which will improve maintainability and reduce the risk of errors.
Workflow ID: wflow_CXlcL1xY7mRc6uno
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Added export functionality for collections, documents, conversations, users, and more to CSV files, with superuser restrictions and comprehensive tests.
collections_router.py
,conversations_router.py
,documents_router.py
,users_router.py
, andgraphs_router.py
.ConversationsSDK
,DocumentsSDK
,UsersSDK
.test_collections.py
andtest_graphs.py
to verify export functionality..pre-commit-config.yaml
to simplifyisort
command.This description was created by for b1af2de. It will automatically update as commits are pushed.