Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/change default url #1738

Merged
merged 5 commits into from
Dec 29, 2024
Merged

Feature/change default url #1738

merged 5 commits into from
Dec 29, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Dec 28, 2024

Important

Update default API base URL and enhance database, CLI, and SDK functionalities with improved testing and user-specific rate limits.

  • Behavior:
    • Change default --base-url in command_group.py and async_client.py to https://api.cloud.sciphi.ai.
    • Update CLI examples in system_router.py, users_router.py, and other routers to reflect new default URL.
  • Database:
    • Modify QueryBuilder in base.py to use PostgreSQL-style parameterization.
    • Add limits_overrides field to User model in user.py.
    • Enhance PostgresLimitsHandler in limits.py to support user-specific rate limits.
  • Testing:
    • Add integration tests for user limits and filters in test_users.py and test_filters.py.
    • Refactor and add unit tests for conversations and documents in test_conversations.py and test_documents.py.
  • Misc:
    • Update NaClCryptoProvider in nacl.py to improve API key generation.
    • Refactor R2RAsyncClient in async_client.py to handle binary responses.

This description was created by Ellipsis for f36795d. It will automatically update as commits are pushed.

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review December 29, 2024 00:47
@emrgnt-cmplxty emrgnt-cmplxty merged commit 0035d74 into main Dec 29, 2024
2 of 3 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f36795d in 1 minute and 30 seconds

More details
  • Looked at 4715 lines of code in 39 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. py/core/database/base.py:56
  • Draft comment:
    Ensure that all parts of the code interacting with self.params are updated to handle the list format correctly. The order of parameters in the list must match the order expected by the SQL query.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. py/shared/abstractions/user.py:57
  • Draft comment:
    Ensure limits_overrides is correctly handled in all parts of the code where user data is processed, including serialization, deserialization, and database interactions.
  • Reason this comment was not posted:
    Comment did not seem useful.
3. py/tests/unit/test_limits.py:214
  • Draft comment:
    Remove or replace print statements with assertions to keep the test clean and focused on validation.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The test for test_user_level_override is well-structured, but it includes print statements for debugging. These should be removed or replaced with assertions to ensure the test remains clean and focused on validation rather than logging.
4. py/tests/unit/test_limits.py:187
  • Draft comment:
    Consider using dynamically generated UUIDs and email addresses to ensure test isolation and avoid potential conflicts.
  • Reason this comment was not posted:
    Confidence changes required: 40%
    The test_user_level_override function is testing user-specific rate limit overrides. The test is comprehensive, but it includes hardcoded UUIDs and email addresses, which could be replaced with dynamically generated values to ensure test isolation and avoid potential conflicts.

Workflow ID: wflow_RD7OS2EFBPqb7aqD


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant