Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service level type errors #1732

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Fix service level type errors #1732

merged 1 commit into from
Dec 26, 2024

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Dec 26, 2024

Important

Fix type errors by removing Optional from R2RServices and renaming methods in graph_router.py.

  • Type Annotations:
    • Remove Optional from R2RServices attributes in abstractions.py, ensuring services are always present.
  • Method Renames:
    • Rename get_entities to list_entities in graph_router.py for Python and listEntities for JavaScript.
  • Service Creation:
    • Simplify _create_services in builder.py by removing overrides and directly instantiating services.

This description was created by Ellipsis for 160cc7d. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 160cc7d in 16 seconds

More details
  • Looked at 80 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/core/main/assembly/builder.py:80
  • Draft comment:
    Ensure that all services are instantiated correctly since R2RServices no longer allows None values for its attributes.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_7tMRplYossKya9Co


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit 76ce750 into main Dec 26, 2024
14 checks passed
@NolanTrem NolanTrem deleted the Nolan/ServiceTypeErrors branch December 26, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant